-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(50375): Errors for missing enum-named properties should attempt to preserve names #50382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new method seems better, but the flags don't look right. Maybe rewrite them as shifts like the others flags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're running out of flags - does it make sense to have merge any of these flags at all?
Maybe that makes sense, however, I'm not sure which options can be combined. |
I'm unfortunately not seeing anything we could do to make this better; I think it's the case that we can use up to the full 32-bit range, so it's not a problem now, but... |
I believe that for 64-bit versions of Node.js that's the case; but 64-bit Electron may have different rules due to its pointer compression encoding (see microsoft/vscode#151245). If I've read this V8 blog post correctly, under that mode an SMI doesn't get a full 32 bits. |
If Electron behaves differently, maybe we should be testing it; I bet it'd be straightforward to create a builder that does an |
Fixes #50375